Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace coords() with setPixel() and getPixel() #9

Open
victoriafoxgirl opened this issue Mar 4, 2021 · 0 comments
Open

Replace coords() with setPixel() and getPixel() #9

victoriafoxgirl opened this issue Mar 4, 2021 · 0 comments
Labels
compability/generalization less hard-coded things are better

Comments

@victoriafoxgirl
Copy link
Owner

directly manipulating the LED array with pointers may be a bad idea, even though we do have our dummy led for parameter faults.
When using a setPixel() and getPixel() function, this may be more general so future compability is assured.

on the Other hand, keep the choords() function for advanced stuff like calling CRGB::methods, and just have a getPixel/setPixel function that acts as a wrapper around choords()
@victoriafoxgirl victoriafoxgirl added the compability/generalization less hard-coded things are better label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compability/generalization less hard-coded things are better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@victoriafoxgirl