Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The config value for fragLoadingMaxRetryTimeout is not applied in stream- and audio-controller #722

Closed
jeremygio opened this issue Oct 5, 2016 · 1 comment

Comments

@jeremygio
Copy link

Steps to reproduce

Set fragLoadingMaxRetryTimeout in the configuration to a smaller number, like 5.
Have a missing/bad fragment about 30 or 40 seconds into some media.
Begin playback and note when it hits the point of the bad fragment, it can take much longer than a max of 5 seconds to throw the fatal error you'd expect.
You can also just set logging to debug and note the warnings, such as:

[warn] > mediaController: frag loading failed, retry in 16000 ms

Here's a page with the timeout set to 5000. Note the logs.
http://www.theplatcal.com/hlsjs_bug/samples/jg/bad_frag_midroll.html

Expected behavior

I'd expect failure within 5 seconds.

Actual behavior

Depending on the retry cycle, it could take up to 16, 32 or 64 seconds for a fatal error.

This change applies the config value:
jeremygio@50234ad

@mangui mangui closed this as completed in f833813 Oct 5, 2016
@mangui
Copy link
Member

mangui commented Oct 5, 2016

well spotted, thanks @jeremygio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants