Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove MediaInfo struct #107

Closed
flavioribeiro opened this issue Oct 29, 2016 · 3 comments
Closed

remove MediaInfo struct #107

flavioribeiro opened this issue Oct 29, 2016 · 3 comments
Labels
question

Comments

@flavioribeiro
Copy link
Member

This is actually a question/discussion.

We have a MediaInfo field for JobStatus struct, but a list of outputs on the JobOutput struct. Knowing that we can have multiple VideoCodecs, Widths and Heights for a given job, I'm wondering if makes sense to maintain this MediaInfo struct.
@fsouza
Copy link
Collaborator

fsouza commented Oct 29, 2016

Right now, the MediaInfo field contains metadata of the source file, not the output file. We can drop it, but we'd loose all the info from the source media.

@flavioribeiro
Copy link
Member Author

oh I gotcha, so #108 is wrong, I'll work on that. Maybe instead of MediaInfo we should call it something like SourceInfo, what do you think?

@flavioribeiro
Copy link
Member Author

ede3cd5 fixes this, thanks @fsouza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fsouza @flavioribeiro