Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vhs-utils to correctly detect mp4 starting with moof/moov #1173

Merged
merged 1 commit into from Jul 26, 2021

Conversation

brandonocasey
Copy link
Contributor

Description

Correctly detects mp4's that start with moof/moov instead of ftyp/styp.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1173 (0ebc8a6) into main (8868569) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   86.47%   86.51%   +0.04%     
==========================================
  Files          39       39              
  Lines        9577     9577              
  Branches     2210     2210              
==========================================
+ Hits         8282     8286       +4     
+ Misses       1295     1291       -4     
Impacted Files Coverage Δ
src/source-updater.js 95.48% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8868569...0ebc8a6. Read the comment docs.

@brandonocasey
Copy link
Contributor Author

Tests are failing in this pull request and main due to chrome v92 I will look into the failures and open another pull request.

@brandonocasey brandonocasey merged commit 464a365 into main Jul 26, 2021
@brandonocasey brandonocasey deleted the fix/moof-moov-mp4 branch July 26, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants