chore: Replace old quality selector #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 42 42
Lines 10761 10761
Branches 2478 2478
=======================================
Hits 9261 9261
Misses 1500 1500 ☔ View full report in Codecov by Sentry. |
gkatsev
reviewed
Feb 2, 2024
scripts/rendition-selector.js
Outdated
There was a problem hiding this comment.
this should be added to https://github.com/videojs/http-streaming/blob/main/scripts/netlify.js#L5
| @@ -92,7 +92,6 @@ | |||
| "videojs-generate-karma-config": "^8.0.1", | |||
| "videojs-generate-rollup-config": "^7.0.0", | |||
| "videojs-generator-verify": "~3.0.1", | |||
| "videojs-http-source-selector": "^1.1.6", | |||
There was a problem hiding this comment.
no objects to replacing but, but there is a new fork of it that includes v8 support: https://github.com/jb-alvarado/videojs-hls-quality-selector
There was a problem hiding this comment.
Let's just use that then
use another selector
gkatsev
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quality selector plugin on the demo page doesn't work with Video.js 8, and the error that logs is distracting noise.
Replaces the quality selector with an alternative plugin.