Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix repeated segments issue during bandwidth update" #1488

Conversation

dzianis-dashkevich
Copy link
Contributor

Reverts #1477

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef71ff3) 86.06% compared to head (79851bf) 86.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1488   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files          42       42           
  Lines       10764    10752   -12     
  Branches     2478     2474    -4     
=======================================
- Hits         9264     9254   -10     
+ Misses       1500     1498    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkatsev
Copy link
Member

gkatsev commented Feb 21, 2024

fyi, the conventional changelog prefix for revert is revert:

@dzianis-dashkevich
Copy link
Contributor Author

fyi, the conventional changelog prefix for revert is revert:

Thank you! I will update the commit message during the merge. (I created this PR automatically using the GitHub Revert button.)

@gkatsev
Copy link
Member

gkatsev commented Feb 21, 2024

TIL. didn't know they had a revert button.

@dzianis-dashkevich dzianis-dashkevich merged commit 75f7b1a into main Feb 21, 2024
15 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the revert-1477-fix-repeated-segments-issue-during-bandwidth-update branch February 21, 2024 01:14
@dzianis-dashkevich
Copy link
Contributor Author

Yeah, this one:
CleanShot 2024-02-20 at 20 15 07@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants