Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requestId init tag #1518

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: requestId init tag #1518

merged 1 commit into from
Jun 12, 2024

Conversation

adrums86
Copy link
Contributor

Description

When handling a encrypted init segment -init was being added to the requestId erroneously.

Specific Changes proposed

  • Remove the -init addition, as it is added to the id below when the request is made without changing the actual requestId itself.
  • Add a test to ensure requestId is unchanged when decrypting an init segment.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (5f2af5f) to head (12e3c21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   86.31%   86.31%   -0.01%     
==========================================
  Files          43       43              
  Lines       11098    11097       -1     
  Branches     2532     2532              
==========================================
- Hits         9579     9578       -1     
  Misses       1519     1519              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 merged commit a542ec8 into main Jun 12, 2024
14 checks passed
@adrums86 adrums86 deleted the fix-requestId branch June 12, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants