Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: export corrections #68

Merged
merged 1 commit into from Mar 27, 2018
Merged

refactor: export corrections #68

merged 1 commit into from Mar 27, 2018

Conversation

forbesjo
Copy link
Contributor

No description provided.

gkatsev
gkatsev approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not refactor: tag?

@forbesjo forbesjo changed the title ignore: export corrections refactor: export corrections Mar 27, 2018
@forbesjo
Copy link
Contributor Author

Didn't realize there was a refactor tag

@forbesjo forbesjo merged commit aab3b90 into videojs:master Mar 27, 2018
@forbesjo forbesjo deleted the correct-exports branch March 27, 2018 20:23
@gkatsev
Copy link
Member

gkatsev commented Mar 27, 2018

available types: https://github.com/videojs/conventional-changelog-videojs/blob/master/convention.md#type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@forbesjo @gkatsev