feat: add support for a frame-rate attribute #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 94.30% 94.34% +0.03%
==========================================
Files 18 19 +1
Lines 773 778 +5
Branches 241 242 +1
==========================================
+ Hits 729 734 +5
Misses 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. |
6 tasks
gesinger
reviewed
Jul 27, 2022
There was a problem hiding this comment.
Looks good, thank you @gjanblaszczyk . One minor suggestion, but otherwise I think we just need to wait on the decision for videojs/m3u8-parser#150 to merge.
src/utils/string.js
Outdated
| @@ -0,0 +1,10 @@ | |||
| /** | |||
| * Converts the provided string value that may contain the division operation to the number value. | |||
There was a problem hiding this comment.
Suggested change
| * Converts the provided string value that may contain the division operation to the number value. | |
| * Converts the provided string that may contain a division operation to a number. |
There was a problem hiding this comment.
Thanks, I have just updated the comment for the function. By the way, I added you as a reviewer to the related PR for a "httpstreaming" repo (videojs/http-streaming#1289).
gkatsev
approved these changes
Jul 28, 2022
gesinger
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds support for the 'FRAME-RATE' attribute. To make an mpd parser consistent with the m3u8 parser.