feat: parse content steering info #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 94.58% 94.66% +0.07%
==========================================
Files 19 19
Lines 812 824 +12
Branches 247 251 +4
==========================================
+ Hits 768 780 +12
Misses 44 44
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dzianis-dashkevich
approved these changes
Aug 9, 2023
adrums86
reviewed
Aug 9, 2023
|
LGTM |
adrums86
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Add support for parsing
<ContentSteering>tags, as well as content (serverURL), thedefaultServiceLocation,proxyServerUrl, andqueryBeforeStartattributes associated to that tag.This also adds support for
<BaseURLtag properties to be included in our parsing of playlists, but specifically for our case, we ensure theserviceLocationproperty is passed when it exists on a BaseURL tag.Changes
contentSteeringproperty on the parsed output containing the content of the tag asserverURL, as well as the other properties on the tag.serviceLocationproperty in theattributesobject in playlist items.<BaseURL>to be passed into theattributesobject in playlist items.eventHandleroption that will handle events (to be replaced with stream parsing).References
https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-4.4.6.6