Skip to content

Commit

Permalink
fix: Make boolean attributes set and check both the associated proper…
Browse files Browse the repository at this point in the history 
…ty and the attribute (#4631)

Make boolean attributes like muted set the property video.muted = {{boolean}} and the attribute video.setAttribute('muted', 'muted') when changing the value.
Also, in html5's createEl, we were setting/updating attributes for various properties but we were only setting the attributes and not also the properties but also autoplay was happening first rather than last which caused autoplay to fail because muted and playsinline weren't necessary set by that time.

This is the 5.x version of #4562.

Fix #4351.
  • Loading branch information
@gkatsev @misteroneill
gkatsev authored and misteroneill committed Oct 2, 2017
1 parent 23c7f26 commit 0f8de52
Show file tree
Hide file tree
Showing 2 changed files with 208 additions and 160 deletions.

0 comments on commit 0f8de52

Please sign in to comment.