Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering the MenuButton using the keyboard cause the top menu item to be triggered. #1446

Closed
mynameisstephen opened this issue Aug 25, 2014 · 1 comment · Fixed by #1447
Labels

Comments

@mynameisstephen
Copy link

  1. Add a alert or console.log to vjs.MenuItem.prototype.onClick
  2. Using the keyboard tab to a Menu Button such as Captions hit enter.
  3. The top menu item is triggered.
@heff
Copy link
Member

heff commented Aug 26, 2014

Thanks for finding this! I don't know yet if this is the same issue but I discovered the keyboard events are bubbling unexpectedly and submitted #1452. I'm hoping fixing that one can also fix this issue, though I'm about to dig into your PR too.

@heff heff added the bug label Aug 26, 2014
@heff heff closed this as completed in #1447 Sep 3, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants