You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In 4.6.0, requestFullScreen() was renamed to requestFullscreen(). According to semver, removal of the old form probably should have waiting until version 5.0. In the future, I propose that we keep the old method name, log a warning about deprecation, and delegate to the "modernized" equivalent.
The text was updated successfully, but these errors were encountered:
I missed the docs and thought the removal was intentional. I'm not sure why but it looks like requestFullScreen() is another victim of aggressive minification: http://jsbin.com/lalahaliyoda/1/edit. I see it in the externs though. Any idea what happened here?
@dmlap so the issue was the difference between exports and externs. Externs don't guarantee the function will exist in the final compile. Closure may still decide to remove the function if it doesn't look like it's being used internally anywhere.
In 4.6.0,
requestFullScreen()
was renamed torequestFullscreen()
. According to semver, removal of the old form probably should have waiting until version 5.0. In the future, I propose that we keep the old method name, log a warning about deprecation, and delegate to the "modernized" equivalent.The text was updated successfully, but these errors were encountered: