Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine API for externally subclassing components #2035

Closed
heff opened this issue Apr 14, 2015 · 1 comment
Closed

Determine API for externally subclassing components #2035

heff opened this issue Apr 14, 2015 · 1 comment
Labels
confirmed enhancement
Milestone
v5.0.0

Comments

@heff
Copy link
Member

heff commented Apr 14, 2015

With 5.0 we've switched to ES6 classes, but we still need a way for projects that aren't using ES6 to subclass components, e.g. techs.

The current proposal is videojs.extends to match the ES6 terminology. videojs.inherits could be an alias (if that makes sense) to match the Node naming.
@heff heff added this to the v5.0.0 milestone Apr 14, 2015
This was referenced Apr 27, 2015
Closed
Closed
@heff
Copy link
Member Author

heff commented Apr 28, 2015

Closed by #2078

@heff heff closed this as completed Apr 28, 2015
@heff heff added the confirmed label Apr 28, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed enhancement
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
1 participant
@heff