-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to enable Greenkeeper 🌴 #3777
Conversation
@@ -104,7 +105,7 @@ | |||
"markdown-table": "^1.0.0", | |||
"npm-run": "^4.1.0", | |||
"proxyquireify": "^3.0.0", | |||
"qunitjs": "^1.23.1", | |||
"qunitjs": "1.23.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't upgrade to 2.x of qunit until we officially remove support for IE8.
@@ -64,28 +64,29 @@ | |||
"es6-shim": "^0.35.1", | |||
"ghooks": "^1.3.2", | |||
"gkatsev-grunt-sass": "^1.1.1", | |||
"grunt": "^0.4.4", | |||
"grunt": "^0.4.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grunt has to remain in 0.4.x because grunt-github-releaser
requires it as a peer dependency.
"grunt-videojs-languages": "0.0.4", | ||
"grunt-zip": "0.10.2", | ||
"grunt-zip": "0.17.1", | ||
"istanbul": "^0.4.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browserify-istanbul requires istanbul to be installed manually.
Let’s get started with automated dependency management for video.js 💪
This pull request updates all your dependencies to their latest version. Having them all up to date really is the best starting point. I will look out for further dependency updates and make sure to handle them in isolation and in real-time, as soon as you merge this pull request.
✅ If this pull request passes and everything is still working
This is really good news. Merge this pull request and I will keep you posted about dependency updates you shouldn’t miss.
❌ If this pull request fails and things aren’t working
Note: I won’t start sending you further updates, unless you have merged this very pull request.
So, how do we proceed? I suggest you find out what dependency update is causing the problem. Adapt your code so things are working nicely together again. next-update is a really handy tool to help you with this.
Push the changes to this branch and merge it.
In case you can not, or do not want to update a certain dependency right now, you can of course just change the
package.json
file back to your liking.Don’t forget to push your changes to this branch, and merge this pull request, so I can start sending you further updates.
How to update this pull request
How to ignore certain dependencies
Add a
greenkeeper.ignore
field to yourpackage.json
, containing a list of dependencies you don’t want to update right now.How the updates will look like
As soon as you merge this pull request I’ll create a branch for every dependency update, with the new version applied. The branch creation should trigger your testing services to check the new version. Using the results of these tests I’ll try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.
In the above example you can see an in-range update.
1.7.0
is included in the old^1.6.0
range, because of the caret^
character .When the test services report success I’ll delete the branch again, because no action needs to be taken – everything is fine.
When there is a failure however, I’ll create an issue so you know about the problem immediately.
This way every single version update of your dependencies will either continue to work with your project, or you’ll get to know of potential problems immediately.
In this example the new version
4.0.0
is not included in the old^3.0.0
range.For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.
Now you no longer need to check for exciting new versions by hand – I’ll just let you know automatically.![:shipit: :shipit:](https://github.githubassets.com/images/icons/emoji/shipit.png)
And the pull request will not only serve as a reminder to update. In case it passes your decent test suite that’s a strong reason to merge right away
Not sure how things are going to work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Good luck with your project and see you soon ✨
Your Greenkeeper Bot 🌴