Time Tooltips #3836
Merged
Time Tooltips #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also fix #3658 as part of this PR. |
|
Or rather, fix #3645 |
misteroneill
force-pushed
the
time-tooltips
branch
from
51bbbc3
to
322293d
Compare
|
Yep, I noticed that and have fixed it! |
misteroneill
force-pushed
the
time-tooltips
branch
2 times, most recently
from
30620e7
to
ddc318e
Compare
|
I rebased out the changes from #3829 - I don't think they were truly necessary here. |
misteroneill
force-pushed
the
time-tooltips
branch
3 times, most recently
from
12076a1
to
50beaec
Compare
|
This isn't perfect, but I think it's getting close. There are a few very minor edge cases to iron out and the tests need fixing. |
misteroneill
force-pushed
the
time-tooltips
branch
from
78c829c
to
5974db5
Compare
|
This looks pretty nice. |
|
Ok, I think we want to merge this for the RC without addressing the issue but we should address the issue shortly after. |
gkatsev
approved these changes
Jan 18, 2017
This eliminates the keepTooltipsInside option and fixes issue videojs#3645 by forcing a limitation on the calculated position of the tooltip.
This is mostly complete. The only exception to that is that we are not yet ensuring that TimeTooltip components remain inside the player.
misteroneill
force-pushed
the
time-tooltips
branch
from
5974db5
to
8f8965c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the
keepTooltipsInsideoption and makes that the default behavior.It will also involve some refactoring to optimize performance since this is somewhere that we spend a fair amount of time.
Requirements Checklist