Remove method Chaining from videojs #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Dec 19, 2016
misteroneill
added
confirmed
and removed
needs: LGTM
gkatsev
approved these changes
Dec 29, 2016
| */ | ||
| open() { | ||
| if (!this.opened_) { |
There was a problem hiding this comment.
wouldn't been better to not refactor this method and just remove the chaining capabilities for this PR.
There was a problem hiding this comment.
will revert this refactor and add to another PR
| @@ -592,7 +592,7 @@ class Player extends Component { | |||
| * The value to set the `Player's heigth to. | |||
| * | |||
| * @return {number} | |||
| * The current heigth of the `Player`. | |||
| * The current heigth of the `Player` when getting. | |||
There was a problem hiding this comment.
just realized there's a typo here: 'heigth' -> 'height'.
| } | ||
|
|
||
| this[privDimension] = parsedVal; | ||
| } | ||
|
|
||
| this.updateStyleEl_(); | ||
| return this; | ||
| return; |
don't refactor ModalDialog#open don't return for no reason in Player#dimension
|
@gkatsev rebased, and code review changes addressed |
5 tasks
|
removed method chaining changes from |
|
Fixes #3704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specific Changes proposed
List of methods that were changed:
Requirements Checklist