fix: remote text track deprecation warnings #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
commented
Dec 15, 2016
| @@ -178,6 +178,8 @@ QUnit.test('Plugins should not get events after stopImmediatePropagation is call | |||
|
|
|||
| QUnit.test('Plugin that does not exist logs an error', function(assert) { | |||
|
|
|||
| const origConsole = window.console; | |||
There was a problem hiding this comment.
This change is from #3861
7 tasks
gkatsev
force-pushed
the
fix-remote-track-logs
branch
from
6200e74
to
fee211c
Compare
brandonocasey
approved these changes
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests were printing out a lot of deprecation warnings when using remote text tracks. Also, our own text track display was printing them out itself. This silences them and adds a test for the warning.
The first commit of this PR will be rebased out #3861 is merged.