Don't throw when re-registering a plugin #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
commented
Feb 28, 2017
| throw new Error(`Illegal plugin name, "${name}", already exists.`); | ||
| if (pluginExists(name)) { | ||
| log.warn(`A plugin named "${name}" already exists. You may want to avoid re-registering plugins!`); | ||
| } else if (Player.prototype.hasOwnProperty(name)) { |
There was a problem hiding this comment.
This is an else if because if a plugin exists, it will have a method on the Player.prototype, but if the plugin does not exist and the name matches a Player.prototype method, it's an actual player method.
There was a problem hiding this comment.
This sounds like a reasonable compromise.
gkatsev
approved these changes
Feb 28, 2017
| throw new Error(`Illegal plugin name, "${name}", already exists.`); | ||
| if (pluginExists(name)) { | ||
| log.warn(`A plugin named "${name}" already exists. You may want to avoid re-registering plugins!`); | ||
| } else if (Player.prototype.hasOwnProperty(name)) { |
There was a problem hiding this comment.
This sounds like a reasonable compromise.
|
This should be rebased against master, will make tests run better. |
misteroneill
force-pushed
the
plugin-no-throw
branch
from
057ba55
to
10bb8c1
Compare
gkatsev
reviewed
Mar 2, 2017
| if (pluginExists(name) || Player.prototype.hasOwnProperty(name)) { | ||
| throw new Error(`Illegal plugin name, "${name}", already exists.`); | ||
| if (pluginExists(name)) { | ||
| log.warn(`A plugin named "${name}" already exists. You may want to avoid re-registering plugins!`); |
There was a problem hiding this comment.
@misteroneill when you get the chance, can you make another PR that silences this warning in the plugin tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a plugin is re-registered, it will throw an error. On the face, this makes sense, but it comes with two issues:
Requirements Checklist