5.x fix cue-points with a startTime of 0 #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Mar 1, 2017
| @@ -331,7 +335,7 @@ class TextTrack extends Track { | |||
| addCue(originalCue) { | |||
| let cue = originalCue; | |||
|
|
|||
| if (!(originalCue instanceof window.vttjs.VTTCue)) { | |||
| if (window.vttjs && !(originalCue instanceof window.vttjs.VTTCue)) { | |||
There was a problem hiding this comment.
I was mocking vttjs out https://github.com/videojs/video.js/pull/4146/files#diff-3b4ce30c38112a433d137fb9bf1bcbc9R21 but this probably is a better choice.
| @@ -25,7 +27,7 @@ TrackBaseline(TextTrack, { | |||
| mode: 'disabled', | |||
| label: 'English', | |||
| language: 'en', | |||
| tech: defaultTech | |||
| tech: new TechFaker() | |||
There was a problem hiding this comment.
its a suite of tests that runs on it's own, so it won't have access to this.tech as it is not in a QUnit.test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wait for tech to be ready before worrying about timeupdate events
Requirements Checklist