5.x fix: default track selection #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watch for showing tracks on addtrack and remove track This allows default tracks or tracks with a mode of showing to be seen when they are added (as we would expect). Rather than only being seen after the first `modechange` event (aka a selection from the menu).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are currently two issues with
TextTracks that havedefaultset totruewhen added.captions offand the newdefaultcaption button both selectedSpecific Changes proposed
loadstart, rather than justtexttrackchangeas in most cases text tracks will be added before we start to listen fortexttrackchangeaddtrackandremovetracksimilar to how we treatchangenow (watch forcuechangeon any showing tracks and update the display)Requirements Checklist