fix: only change focus from BPB if not a mouse click #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
changed the title
misteroneill
previously requested changes
Jul 24, 2017
src/js/button.js
Outdated
| constructor(player, options) { | ||
| super(player, options); | ||
|
|
||
| this._mouseused = false; |
There was a problem hiding this comment.
Is there a reason this property name doesn't follow other conventions? Most of the time, it's camel case with a trailing underscore (i.e. mouseUsed_).
There was a problem hiding this comment.
I didn't remember where we put the _. I'll move it to the end.
src/js/big-play-button.js
Outdated
| @@ -36,6 +36,11 @@ class BigPlayButton extends Button { | |||
| handleClick(event) { | |||
| const playPromise = this.player_.play(); | |||
|
|
|||
| // exit early if clicked via the mouse | |||
| if (this._mouseused && event.clientX && event.clientY) { | |||
There was a problem hiding this comment.
Could we just use clientX or clientY without mouseused here? could be a terrible idea but I figured I would throw it out there.
src/js/button.js
Outdated
| constructor(player, options) { | ||
| super(player, options); | ||
|
|
||
| this._mouseused = false; |
There was a problem hiding this comment.
Is there any reason not stick this in BigPlayButton instead of the Button class?
There was a problem hiding this comment.
You're right. That would be better since I want this as self contained as possible.
brandonocasey
approved these changes
Jul 25, 2017
misteroneill
approved these changes
Jul 25, 2017
brandonocasey
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to not change the focus to the play toggle from the Big Play Button when clicking on it with the mouse.
There's still work to be done with regards to the focus ring and mouse vs key events but that's for another time and would probably be more involved.
We cancel out focus changing if the mouse was used to click the button, or, as far as we could tell via the
mousedownhandler. Unfortunately, using VoiceOver's functionality (via control-option space), we also get amousedownevent. However, those events do not addclientXandclientYto theclickevent like a true mouse event does.