feat: Add videojs.hookOnce method to allow single-run hooks. #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Oct 19, 2017
| @@ -140,8 +140,8 @@ videojs.hooks_ = {}; | |||
| * @param {string} type | |||
| * the lifecyle to get hooks from | |||
| * | |||
| * @param {Function} [fn] | |||
| * Optionally add a hook to the lifecycle that your are getting. | |||
| * @param {Function|Function[]} [fn] | |||
There was a problem hiding this comment.
I don't think we should document or officially support multiple handlers in a single hooks call. It just encourages bad code.
There was a problem hiding this comment.
It's already documented for the other function. Was trying to be consistent.
gkatsev
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a
videojs.hookOnce()method, which allows single-run hooks.Also, cleaned up the guide for readability and grammar/spelling/typos.
Requirements Checklist