Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can not drag on drag-bar IE9 #4783

Merged
merged 1 commit into from
Dec 4, 2017
Merged

fix: can not drag on drag-bar IE9 #4783

merged 1 commit into from
Dec 4, 2017

Conversation

kocoten1992
Copy link
Contributor

@kocoten1992 kocoten1992 commented Dec 2, 2017 •
edited
Loading

Requirements Checklist

Note

On handleTechClick_, before the checking was

button.event !== 0 // it work on IE9

Now it become

!dom.isSingleLeftClick // ignore IE9 check, so doesn't work anymore

Could make it to be something like

!dom.isSingleLeftClick && browser.IE_VERSION !== 9
// should we do this or sacrifice IE9 right click pause video to make code cleaner

gkatsev
gkatsev approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals patch This PR can be added to a patch release. labels Dec 4, 2017
@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Dec 4, 2017
@gkatsev gkatsev merged commit 2337c1b into videojs:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kocoten1992 @misteroneill @gkatsev