Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full page broken in Safari in 1.1.3 #48

Closed
fwonkas opened this issue Oct 27, 2010 · 1 comment
Closed

Full page broken in Safari in 1.1.3 #48

fwonkas opened this issue Oct 27, 2010 · 1 comment

Comments

@fwonkas
Copy link

fwonkas commented Oct 27, 2010

Full page is broken in Safari. nativeFullscreenOn isn't returning false when this.video.webkitEnterFullScreen throws an error. Adding a return false in the catch block fixes it:

nativeFullscreenOn: function(){
  if(typeof this.video.webkitEnterFullScreen == 'function') {
    // Seems to be broken in Chromium/Chrome
    if (!navigator.userAgent.match("Chrome")) {
      try {
        this.video.webkitEnterFullScreen();
      } catch (e) {
        if (e.code == 11) { this.errors.push(VideoJS.errorCodes.videoNotReady); }
        return false;
      }
      return true;
    }
  }
},
@fwonkas
Copy link
Author

fwonkas commented Oct 27, 2010

Changed to pull request

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant