Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the Simplified Chinese translations #4827

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Complete the Simplified Chinese translations #4827

merged 1 commit into from
Jan 3, 2018

Conversation

hopechannel
Copy link
Contributor

@hopechannel hopechannel commented Dec 19, 2017 •
edited

Provide the full list of translations for the Simplified Chinese language.

Description

The Simplified Chinese translation was incomplete. This change fully completes the translation into Simplified Chinese.

Specific Changes proposed

lang/zh-CN.json

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Complete the Traditional Chinese translations
61e1c04 
Provide the full list of translations for the Traditional Chinese language.
@hopechannel hopechannel changed the title Complete the Traditional Chinese translations Complete the Simplified Chinese translations Dec 19, 2017
@gkatsev gkatsev added i18n Relation to localisation and translation. needs: LGTM Needs one or more additional approvals patch This PR can be added to a patch release. labels Jan 3, 2018
@hopechannel
Copy link
Contributor Author

Thank you, @gkatsev!

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jan 3, 2018
@gkatsev gkatsev merged commit 98773dd into videojs:master Jan 3, 2018
@hopechannel
Copy link
Contributor Author

Thank you!

@hopechannel hopechannel deleted the patch-1 branch January 3, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@mister-ben mister-ben mister-ben approved these changes

Assignees
No one assigned
Labels
confirmed i18n Relation to localisation and translation. patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hopechannel @gkatsev @mister-ben