Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add project and build names to browserstack #4903

Merged
merged 9 commits into from Jan 26, 2018

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jan 25, 2018

videojs/http-streaming is starting to run tests in browserstack so we should name our runs better.

@gkatsev
Copy link
Member Author

gkatsev commented Jan 25, 2018

Looks like
screen shot 2018-01-25 at 18 23 09

Previously it would just say 7907

@forbesjo
Copy link
Contributor

forbesjo commented Jan 26, 2018

This might be out of the original scope of the PR but you could also turn off video to disable video capture and, I think, speed up VM startup. The recorded video isn't particularly useful since none of the tests have a visual output.

https://github.com/karma-runner/karma-browserstack-launcher#global-options

@gkatsev
Copy link
Member Author

gkatsev commented Jan 26, 2018

Turning it off sounds good to me, though, we do have the qunit output enabled and it has been helpful for IE8 debugging, but we can always add it in manually when needed and re-run the build.

@gkatsev
Copy link
Member Author

gkatsev commented Jan 26, 2018

Looks like turning it off doesn't really make much of a difference in our build times so I'm going to leave them on.

@gkatsev gkatsev merged commit 41fd5cb into master Jan 26, 2018
@gkatsev gkatsev deleted the more-browsers-in-parallel branch January 26, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants