Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow player dimension method to accept 'auto' #6185

Merged
merged 1 commit into from
Aug 29, 2019
Merged

feat: allow player dimension method to accept 'auto' #6185

merged 1 commit into from
Aug 29, 2019

Conversation

klee-frankly
Copy link
Contributor

@klee-frankly klee-frankly commented Aug 19, 2019

Description

Allow the dimension method of the Player module to accept 'auto' as an explicit value.

Specific Changes proposed

Check if dimension value in src/js/player.js's dimension function is 'auto' or '' when deciding to set the dimension to be automatic and return early in the function.

Requirements Checklist

  • [*] Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Aug 19, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but this is a new feature rather than a fix.

@gkatsev gkatsev changed the title fix: allow player dimension method to accept 'auto' feat: allow player dimension method to accept 'auto' Aug 19, 2019
@gkatsev gkatsev added confirmed minor This PR can be added to a minor release. It should not be added to a patch release. labels Aug 19, 2019
@gkatsev gkatsev merged commit 8129f03 into videojs:master Aug 29, 2019
@welcome
Copy link

welcome bot commented Aug 29, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants