Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Update Norwegian translations #6220

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

danmichaelo
Copy link
Contributor

@danmichaelo danmichaelo commented Sep 8, 2019

Add missing translations for Norwegian Bokmål (nb) and Nynorsk (nn).

Note: I translated "Seek to live, currently playing live" as something like "Currently playing live" since I found the original message very odd-sounding. If you are already live, why would you want jump to where you currently are? My guess is that this message was written from a very technical point of view. Would it perhaps be an idea to change the English original too? I can create a separate issue for that if you think it might be a good idea.

@welcome
Copy link

welcome bot commented Sep 8, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev
Copy link
Member

gkatsev commented Oct 4, 2019

The reason for the message is that it is informative to screen reader users. The first piece informs that user that it is a button that when pressed will take them to the live point, the second part informs them whether they are currently live or not. @OwenEdwards may be able to provide a bit more insight into the decision, if there's anything else to add.

@gkatsev
Copy link
Member

gkatsev commented Oct 4, 2019

Also, thanks for updating the translations, it's very much appreciated!

@danmichaelo
Copy link
Contributor Author

danmichaelo commented Oct 4, 2019

Thanks for clarifying. I feel like the best would probably be if the button was not active when you're already playing live since there's no reason to jump to live if you're already live. That goes for users of screen readers and other users alike.

But I'm digressing from the translation :) It's probably better to kep the translation close to the original even when the original is a bit odd so I amended my translation so that it provides the same message as the English original.

@gkatsev
Copy link
Member

gkatsev commented Oct 7, 2019

Thanks! If you think that the text/behavior should be changed, please open another issue.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the translations-needed doc as well!

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gkatsev gkatsev merged commit e37996d into videojs:master Oct 7, 2019
@welcome
Copy link

welcome bot commented Oct 7, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants