fix: IS_IPAD should be false on iPhone #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari user agent. However, the new check also returns true for iPhones. Therefore, we should exclude iPhones from the check. Unfortunately, this means that the iPhone user agent detection on iPhones inside the Facebook app may break again as previously (https://artsy.github.io/blog/2012/10/18/the-perils-of-ios-user-agent-sniffing/) we excluded iPads from the iPhone check but that won't work anymore.
|
Just verified with latest Facebook app on iPhone and they report an iPhone user agent now so there isn't any issue with doing this unless you're using a super old version of facebook. |
misteroneill
approved these changes
Dec 24, 2019
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari user agent. However, the new check also returns true for iPhones.
Therefore, we should exclude iPhones from the check.
Unfortunately, this means that the iPhone user agent detection on
iPhones inside the Facebook app may break again as previously
(https://artsy.github.io/blog/2012/10/18/the-perils-of-ios-user-agent-sniffing/) we
excluded iPads from the iPhone check but that won't work anymore.