Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: Improving Russian translation #7740

Merged
merged 2 commits into from May 18, 2022
Merged

lang: Improving Russian translation #7740

merged 2 commits into from May 18, 2022

Conversation

AHOHNMYC
Copy link
Contributor

@AHOHNMYC AHOHNMYC commented Apr 27, 2022 •
edited

Description

Improving Russian translation and adding missing phrases.

@welcome
Copy link

welcome bot commented Apr 27, 2022

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

misteroneill
misteroneill approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but I don't speak Russian.

@roman-bc-dev Would you be able to take a look at this one?

@codecov
Copy link

codecov bot commented May 2, 2022 •
edited

Codecov Report

Merging #7740 (67f295c) into main (0543298) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7740   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         116      116           
  Lines        7457     7457           
  Branches     1806     1806           
=======================================
  Hits         6033     6033           
  Misses       1424     1424

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0543298...67f295c. Read the comment docs.

roman-bc-dev
roman-bc-dev reviewed May 3, 2022
View reviewed changes
lang/ru.json
"Done": "Готово",
"Caption Settings Dialog": "Диалог настроек подписи",
"Beginning of dialog window. Escape will cancel and close the window.": "Начало диалоговго окна. Кнопка Escape закроет или отменит окно",
"Beginning of dialog window. Escape will cancel and close the window.": "Начало диалогового окна. Нажмите Escape для отмены и закрытия окна",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. Good change here!

@misteroneill misteroneill merged commit dc24b19 into videojs:main May 18, 2022
@welcome
Copy link

welcome bot commented May 18, 2022

Congrats on merging your first pull request! 🎉🎉🎉

misteroneill pushed a commit that referenced this pull request May 20, 2022
@AHOHNMYC @misteroneill
fix(lang): Improving Russian translation (#7740)
ef7ccfc 
Co-authored-by: meow <woem>
@AHOHNMYC AHOHNMYC deleted the russian-translation branch June 9, 2022 18:34
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@AHOHNMYC @edirub
fix(lang): Improving Russian translation (videojs#7740)
7e4b7eb 
Co-authored-by: meow <woem>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@roman-bc-dev roman-bc-dev roman-bc-dev approved these changes

Assignees
No one assigned
Labels
confirmed patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AHOHNMYC @misteroneill @roman-bc-dev