Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix mixed content warnings from netlify #7946

Merged
merged 1 commit into from Oct 3, 2022
Merged

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Oct 3, 2022

Netlify will email me if it detects mixed content in html it hosts. We fixed the stuff in sandbox/ previously, but the legacy docs apparently still had some. Mostly does some google fonts and vjs cdn http->https.

Copy link
Contributor

@Essk Essk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify will email me if it detects mixed content in html it hosts.

RIP your inbox 😬

Changes all LGTM

@gkatsev
Copy link
Member Author

gkatsev commented Oct 3, 2022

Thankfully, it only sent one email per PR and not one email per item 😆

@gkatsev gkatsev merged commit ce1baba into main Oct 3, 2022
@gkatsev gkatsev deleted the insecure-legacy-docs branch October 3, 2022 15:07
@gkatsev
Copy link
Member Author

gkatsev commented Oct 3, 2022

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants