Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: text track display overlays a video #8009

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

gjanblaszczyk
Copy link
Member

Description

Text track display does not always overlay a video which may generate a different text track size and position across different browsers and devices.

Specific Changes proposed

The text track display always overlays a video.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #8009 (0411afc) into main (e49286a) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8009      +/-   ##
==========================================
+ Coverage   80.98%   81.19%   +0.21%     
==========================================
  Files         116      116              
  Lines        7472     7494      +22     
  Branches     1817     1821       +4     
==========================================
+ Hits         6051     6085      +34     
+ Misses       1421     1409      -12     
Impacted Files Coverage Δ
src/js/tracks/text-track-display.js 84.12% <100.00%> (+2.09%) ⬆️
src/js/utils/browser.js 54.32% <0.00%> (ø)
src/js/tech/html5.js 67.50% <0.00%> (+0.20%) ⬆️
src/js/player.js 88.76% <0.00%> (+0.38%) ⬆️
src/js/tech/tech.js 83.56% <0.00%> (+0.56%) ⬆️
...rc/js/control-bar/progress-control/time-tooltip.js 84.61% <0.00%> (+2.56%) ⬆️
src/js/control-bar/picture-in-picture-toggle.js 82.75% <0.00%> (+3.44%) ⬆️
src/js/control-bar/control-bar.js 100.00% <0.00%> (+16.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this works well!
Had a couple of minor comments.

src/js/tracks/text-track-display.js Outdated Show resolved Hide resolved
src/js/tracks/text-track-display.js Outdated Show resolved Hide resolved
src/js/tracks/text-track-display.js Outdated Show resolved Hide resolved
@gjanblaszczyk gjanblaszczyk merged commit 1491d71 into videojs:main Apr 11, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants