Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing translations #8083

Merged
merged 2 commits into from
Jan 23, 2023
Merged

chore: add missing translations #8083

merged 2 commits into from
Jan 23, 2023

Conversation

adrums86
Copy link
Contributor

Description

Adding some missing translations as the result of some localization work.

Specific Changes proposed

Adding some of the missing ar, de, es, fr, ja, ko, zh-CN and zh-TW translations and update the translations-needed.md

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@adrums86 adrums86 self-assigned this Jan 19, 2023
@welcome
Copy link

welcome bot commented Jan 19, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #8083 (c354c08) into main (df71bb0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8083   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files         110      110           
  Lines        7342     7342           
  Branches     1772     1772           
=======================================
  Hits         6014     6014           
  Misses       1328     1328           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alex-barstow alex-barstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big help, thanks!

@adrums86 adrums86 merged commit e21d295 into main Jan 23, 2023
@adrums86 adrums86 deleted the translations branch January 23, 2023 18:44
@welcome
Copy link

welcome bot commented Jan 23, 2023

Congrats on merging your first pull request! 🎉🎉🎉

dzianis-dashkevich added a commit that referenced this pull request Jan 31, 2023
* chore: add missing translations (#8083)

* fix wrong translation (#8091)

---------

Co-authored-by: Adam Waldron <acwald@gmail.com>
Co-authored-by: Liberal dev <56965274+liberaldev@users.noreply.github.com>
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants