feat(error): remove confusing decorative X from error display modal #8553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8553 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 113 113
Lines 7614 7614
Branches 1830 1830
=======================================
Hits 6298 6298
Misses 1316 1316 ☔ View full report in Codecov by Sentry. |
misteroneill
approved these changes
Jan 9, 2024
adrums86
approved these changes
Jan 9, 2024
CarlosVillasenor
changed the title
Modify _error: -Remove the ‘x’ decorative element from the error display modal.
CarlosVillasenor
force-pushed
the
fix/remove-error-x
branch
from
f799741
to
5779400
Compare
Done on both: the PR title & pushed commit on the PR |
misteroneill
approved these changes
Jan 10, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify _error:
-Remove confusing decorative X from error display modal.
Description
Remove confusing decorative X from pseudo-class on error modal.
Specific Changes proposed
Remove pseudo-class :before on vjs-error-display.
Requirements Checklist