Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pip enter event with window metadata #8591

Merged
merged 1 commit into from Feb 20, 2024

Conversation

wseymour15
Copy link
Contributor

Description

Update enterpictureinpicture event to send window metadata on trigger.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@wseymour15 wseymour15 marked this pull request as ready for review February 15, 2024 17:58
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (395d608) 82.71% compared to head (2d7f213) 82.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8591   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7636     7636           
  Branches     1835     1835           
=======================================
  Hits         6316     6316           
  Misses       1320     1320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wseymour15 wseymour15 self-assigned this Feb 16, 2024
@wseymour15 wseymour15 merged commit 4c1f63b into main Feb 20, 2024
13 checks passed
@wseymour15 wseymour15 deleted the chore/update-pip-event-with-window-metadata branch February 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants