Why player.volume(val) fires volumechange event?

[morskoyzmey]

Example. Once user changes volume in one player I want to set that volume for all the rest players on the page.
I'm doing this in volumechange event, where for each player (except current) I call p.volume(new_val). But each such call fires another volumechange event. So we get the recursion here, which breaks only because there is no event for unchanged value.

That behaviour I barely met in any API I've used before.

Video.js 8.6.1

[welcome]

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[amtins]

@morskoyzmey This behavior is specific to the mediaElement. The recursion should stop by itself after a few executions, because if the same value is passed to the mediaElement, it is not supposed to emit a new volumenchange event. But it is possible to do something like:

videojs.getAllPlayers().forEach((player) => {
  player.on('volumechange', () => {
    const volume = player.volume();

    videojs.getAllPlayers().forEach((playerToUpdate) => {
      if (player === playerToUpdate || playerToUpdate.volume() === volume) return;

      playerToUpdate.volume(volume);
    });
  });
});

[mister-ben]

That behaviour I barely met in any API I've used before.

This is the same behaviour of a plain video element. volumechange is triggered when you set <video>.volume to a new value.