-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YouTube/Google] ads are not loaded, VIDEOJS crash #55
Comments
@santiagohdzb the example you reference seems to have gone away. Is there any chance you could produce another (ideally, isolated) example? |
@dmlap i didn't make a copy. It belongs to @seekerquoc. The code was very easy, so let me try if i can reproduce same issue |
http://imasdk.googleapis.com/js/sdkloader/ima3.js stands for Google IMA SDK and they have own videojs plugin integrating ads. IMHO you should first try using it. |
Haven't heard back on this one in awhile, so I'm going to close it. If you're still running into issues, I would recommend giving @mente's advice a shot. |
when you try to load this:
http://nhanhoasolutions.com/tam/html/ima/tam.html
the main problem appears to be whenever this is loaded:
http://imasdk.googleapis.com/js/sdkloader/ima3.js
it sends the video ads to the client, in this case the browser but they are not shown because VIDEOJS already crashed so you have to refresh the page or click the play triangle twice in order to see the ads
so in my conclusion google/youtube is taking so much time to send the video ads or at least more time than videojs.ads.js:275 appears to wait for them so it triggers an error and crash. After this if you click the play triangle twice or refresh the page it already has the ads so it doesn't trigger the error.
maybe the solution could be changing the 5000 for 7000 or adding an extra Timeout layer... thanks
original reported by: @seekerquoc
The text was updated successfully, but these errors were encountered: