chore: Update generate-rollup-config to drop older browser support #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-barstow
changed the title
alex-barstow
commented
Aug 10, 2022
| "shx": "^0.3.2", | ||
| "sinon": "^6.1.5", | ||
| "videojs-generate-karma-config": "^5.1.0", | ||
| "videojs-generate-rollup-config": "^3.1.0", | ||
| "videojs-generate-karma-config": "^8.0.1", |
There was a problem hiding this comment.
Also update version of this package which has removed older browserstack launchers
alex-barstow
commented
Aug 10, 2022
| @@ -219,7 +219,7 @@ QUnit.test('error in webkitSetMediaKeys rejects promise', function(assert) { | |||
| } | |||
| }; | |||
|
|
|||
| window.WebKitMediaKeys = () => {}; | |||
| window.WebKitMediaKeys = function() {}; | |||
There was a problem hiding this comment.
Arrow functions aren't constructable since they are no longer transpiled into ES5. That was throwing some errors in tests.
gkatsev
approved these changes
Aug 11, 2022
| @@ -64,21 +64,17 @@ | |||
| "npm-merge-driver-install": "^1.0.0", | |||
| "npm-run-all": "^4.1.3", | |||
| "pkg-ok": "^2.2.0", | |||
| "rollup": "^0.65.0", | |||
| "rollup": "^2.2.0", | |||
misteroneill
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the default browserslist used by babel. It drops support for some older browsers including IE 11. This also removes the
browserslistinpackage.jsonso we use the default list from@videojs/babel-config(linked above).The plan is to merge this into
mainand do a major version release.NOTE: Merge with
BREAKING CHANGEheader