Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eventBus error after dispose #218

Merged
merged 9 commits into from
May 16, 2024
Merged

fix: eventBus error after dispose #218

merged 9 commits into from
May 16, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented May 3, 2024

fix an issue where the eventBus reference is destroyed before a keystatuseschange event is fired after a despose() call on the player.

src/eme.js Outdated Show resolved Hide resolved
@dzianis-dashkevich
Copy link
Contributor

I assume, we should update all occurrences across the plugin

@adrums86
Copy link
Contributor Author

Fixed any other unsafe calls to eventBus.trigger and fixed remaining tests. Also update the lint standard to allow for use of the spread operator for objects.

@adrums86 adrums86 merged commit 730bdd9 into main May 16, 2024
4 checks passed
@adrums86 adrums86 deleted the fix-eventBus-trigger branch May 16, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants