chore: Update using plugin generator v7.2.4 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
changed the title
brandonocasey
force-pushed
the
chore/generator-v7
branch
from
40110a4
to
6fd184d
Compare
forbesjo
reviewed
Sep 4, 2018
src/plugin.js
Outdated
| @@ -28,7 +28,7 @@ export const hasSession = (sessions, initData) => { | |||
| // is safe though, and might be a good idea to retain in the short term (until we have | |||
| // catalogued the full range of browsers and their implementations). | |||
| if (arrayBuffersEqual(arrayBufferFrom(sessions[i].initData), | |||
| arrayBufferFrom(initData))) { | |||
| arrayBufferFrom(initData))) { | |||
There was a problem hiding this comment.
Due to the new indentation handling in eslint 4, this is what is required. We could put all the code on one line instead of this instead.
There was a problem hiding this comment.
Maybe split this into variables for readability?
forbesjo
reviewed
Sep 4, 2018
scripts/karma.conf.js
Outdated
|
|
||
| module.exports = function(config) { | ||
| const options = { | ||
| customLaunchers(defaults) { |
There was a problem hiding this comment.
I think the default videojs-generate-karma-config browser set up should work since contrib-eme doesn't have e2e playback tests
brandonocasey
force-pushed
the
chore/generator-v7
branch
from
956d92a
to
9239a82
Compare
brandonocasey
changed the title
brandonocasey
changed the title
misteroneill
approved these changes
Sep 5, 2018
forbesjo
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes