feat: Add support for defining custom headers for default license and certificate requests. #76
Conversation
|
I think |
|
@gkatsev Yeah it is definitely too generic. I left it as such until we can establish the following: should we allow headers to be set only on license requests? Or also certificate and key requests? |
|
I think we ought to allow custom headers for any of the default requests contrib-eme can make. |
misteroneill
force-pushed
the
add-headers-emeOption
branch
from
6a2ccee
to
3344b20
Compare
…ySystems to override values from options.
misteroneill
changed the title
headers emeOption (WIP)
| const defaultGetLicense = (url) => (emeOptions, keyMessage, callback) => { | ||
| const defaultGetLicense = (keySystemOptions) => (emeOptions, keyMessage, callback) => { | ||
| const headers = videojs.mergeOptions( | ||
| {'Content-type': 'application/octet-stream'}, |
There was a problem hiding this comment.
Since you're now providing options to add headers, any chance you could not include this by default? For whatever reason, our DRM provider doesn't have Content-Type in the Access-Control-Allow-Headers header, so I provide a custom function just so this header isn't there.
There was a problem hiding this comment.
do you think there would be issues in removing it? I've got no major objections unless removing it may break someone.
There was a problem hiding this comment.
What if we allowed removing headers by setting them to null or something, so you could do:
licenseHeaders: {
'Content-Type': null
}I am hesitant to remove defaults because it could easily break someone.
No description provided.