test: Update dependencies and fix test that fails in Safari. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Mar 14, 2019
test/eme.test.js
Outdated
| @@ -494,6 +494,13 @@ QUnit.test('5 July 2016 lifecycle', function(assert) { | |||
| }); | |||
|
|
|||
| QUnit.test('getSupportedKeySystem error', function(assert) { | |||
|
|
|||
| // Skip this test in Safari, getSupportedKeySystem is never used in Safari. | |||
| if (videojs.browser.IS_ANY_SAFARI) { | |||
There was a problem hiding this comment.
It may be better to wrap this test in this check, so that we don't have a false positive for this test on safari.
misteroneill
changed the title
brandonocasey
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies were pretty out of date and I noticed that the tests were failing in Safari, but for a test that didn't need to run in Safari.