fix: Use correct callback function signature for PlayReady license request callbacks. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
commented
May 1, 2019
| @@ -49,6 +49,8 @@ By default, videojs-contrib-eme is not able to decrypt any audio/video. | |||
|
|
|||
| In order to decrypt audio/video, a user must pass in either relevant license URIs, or methods specific to a source and its combination of key system and codec. These are provided to the plugin via either videojs-contrib-eme's plugin options or source options. | |||
|
|
|||
| If you're new to DRM on the web, read [about how EME is used to play protected content on the web](https://developers.google.com/web/fundamentals/media/eme). | |||
|
|
|||
There was a problem hiding this comment.
Added this because it seems like a useful thing for helping users understand the purpose of this plugin.
gkatsev
approved these changes
May 1, 2019
misteroneill
added a commit
that referenced
this pull request
May 1, 2019
misteroneill
added a commit
that referenced
this pull request
May 1, 2019
squarebracket
added a commit
to squarebracket/videojs-contrib-eme
that referenced
this pull request
May 3, 2019
…s#81 PR videojs#81 fixed the callback signature for ms-prefixed, which was incorrect. However, eme was being used correctly, and so the PR broke eme support on Edge.
misteroneill
pushed a commit
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code (and tests) had faulty assumptions about the callback signature of a
videojs.xhr()call. The second argument is not theresponseBodybut theresponseobject.