feat: Add CDM detection module #98
Conversation
src/plugin.js
Outdated
| // Pass a promise polyfill from the player options for IE support. If none | ||
| // exists, native Promises will be used and the function won't be supported in IE | ||
| detectSupportedCDMs: createDetectSupportedCDMsFunc(player.options().Promise), | ||
| getSupportedCDMs, |
There was a problem hiding this comment.
why have a synchronous function for an asynchronous process?
There was a problem hiding this comment.
Could just get rid of it. Curious whether others think it makes sense to remove getSupportedCDMs()
There was a problem hiding this comment.
I think getting rid of getSupportedCDMs is the right call here.
There was a problem hiding this comment.
Looks good. I think removing the sync function is the right call. There also might be some warnings in MDNs docs regarding when to call requestMediaKeySystemAccess that we may want to bubble up to our documentation for this module. https://developer.mozilla.org/en-US/docs/Web/API/Navigator/requestMediaKeySystemAccess
src/plugin.js
Outdated
| // Pass a promise polyfill from the player options for IE support. If none | ||
| // exists, native Promises will be used and the function won't be supported in IE | ||
| detectSupportedCDMs: createDetectSupportedCDMsFunc(player.options().Promise), | ||
| getSupportedCDMs, |
There was a problem hiding this comment.
I think getting rid of getSupportedCDMs is the right call here.
This PR adds two utility methods:
player.eme.getSupportedCDMsandplayer.eme.detectSupportedCDMs.The latter uses
window.navigator.requestMediaKeySystemAccess()to asynchronously detect which CDMs are available in the browser. When that EME API method is unavailable, such as in older Safari versions, other feature detection is used.The former is synchronous and returns either 1) the last result of
detectSupportedCDMs(), or if that hasn't been called, 2) a best guess based solely on the user agent and presence of EME API features.