Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show rotate instructions #75

Merged
merged 3 commits into from
May 23, 2018
Merged

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented May 8, 2018

Description

On initially going into cardboard mode on a device there would be instructions shown, but these instructions would not actually go away. This PR removes them.

Fixes #73

Testing

  • The cardboard mode button should still work on
    • iOS Safari
    • Android Chrome

@ishita12
Copy link

QA LGTM

@brandonocasey brandonocasey merged commit 0c525cd into master May 23, 2018
@brandonocasey brandonocasey deleted the fix/do-not-show-rotate branch May 24, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants