Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PauseControl #31

Closed
1 of 2 tasks
mihar-22 opened this issue Feb 2, 2021 · 2 comments · Fixed by #130
Closed
1 of 2 tasks

PauseControl #31

mihar-22 opened this issue Feb 2, 2021 · 2 comments · Fixed by #130
Labels
component feature New feature or request released ui
Projects
Player 1.0

Comments

@mihar-22
Copy link
Member

mihar-22 commented Feb 2, 2021 •
edited
Loading

Tasks

  • Complete Control #28.
  • Design, build and test the PauseControl component.

Notes

Slots

  • default: Used to pass in a styled element to give the component form.

CSS Parts

Forward all Control parts.

Events

  • vds-user-pause-request: UI event emitted when the component is pressed and to pause playback.

References
@mihar-22 mihar-22 added this to Backlog in Player 1.0 via automation Feb 2, 2021
@mihar-22 mihar-22 changed the title PauseControl UI PauseControl UI Component Feb 2, 2021
@mihar-22 mihar-22 mentioned this issue Feb 2, 2021
Closed
4 tasks
@mihar-22 mihar-22 changed the title PauseControl UI Component PauseControl Feb 2, 2021
@mihar-22 mihar-22 added this to the reddit-wmp-m1 milestone Feb 5, 2021
@mihar-22 mihar-22 moved this from Backlog to Priority in Player 1.0 Feb 10, 2021
@mihar-22 mihar-22 moved this from Priority to In Progress in Player 1.0 Mar 4, 2021
@mihar-22 mihar-22 mentioned this issue Mar 5, 2021
Merged
@mihar-22
Copy link
Member Author

mihar-22 commented Mar 5, 2021

Little difficult to manage ARIA and have this as a separate component. In addition, this component standalone most likely doesn't make sense because playback changes should always be two-way (play/pause). Need solid use-case to consider splitting.

@mihar-22 mihar-22 closed this as completed Mar 5, 2021
Player 1.0 automation moved this from In Progress to Done Mar 5, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component feature New feature or request released ui
Projects
No open projects
Player 1.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: new playback toggle component
1 participant
@mihar-22