Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnmuteControl #34

Closed
1 of 2 tasks
mihar-22 opened this issue Feb 2, 2021 · 1 comment
Closed
1 of 2 tasks

UnmuteControl #34

mihar-22 opened this issue Feb 2, 2021 · 1 comment
Labels
component feature New feature or request ui
Projects

Comments

@mihar-22
Copy link
Member

mihar-22 commented Feb 2, 2021

Tasks

  • Complete Control #28.
  • Design, build and test the UnmuteControl component.

Notes

Slots

  • default: Used to pass in a styled element to give the component form.

CSS Parts

Forward all Control parts.

Events

  • vdsUserUnmuteRequest: UI event emitted when the component is pressed to unmute volume.

References

@mihar-22 mihar-22 added this to Backlog in Player 1.0 via automation Feb 2, 2021
@mihar-22 mihar-22 mentioned this issue Feb 2, 2021
4 tasks
@mihar-22 mihar-22 changed the title UnmuteControl UI Component UnmuteControl Feb 2, 2021
@mihar-22 mihar-22 added this to the reddit-wmp-m1 milestone Feb 5, 2021
@mihar-22 mihar-22 moved this from Backlog to Priority in Player 1.0 Feb 10, 2021
@mihar-22 mihar-22 moved this from Priority to In Progress in Player 1.0 Mar 4, 2021
@mihar-22
Copy link
Member Author

mihar-22 commented Mar 5, 2021

Little difficult to manage ARIA and have this as a separate component. In addition, this component standalone most likely doesn't make sense because mute changes should always be two-way (mute/unmute). Need solid use-case to consider splitting.

@mihar-22 mihar-22 closed this as completed Mar 5, 2021
Player 1.0 automation moved this from In Progress to Done Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component feature New feature or request ui
Projects
No open projects
Development

No branches or pull requests

1 participant