Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo Provider #945

Closed
mihar-22 opened this issue Oct 10, 2023 · 2 comments
Closed

Vimeo Provider #945

mihar-22 opened this issue Oct 10, 2023 · 2 comments
Assignees

Comments

@mihar-22
Copy link
Member

We'll be adding the Vimeo provider to ensure we reach feature parity with Vime/Plyr. I've mentioned many times that I'm not a fan of these embeds as they're very limited and suck for both devs and users, but it's more important we don't leave anyone behind who wants to migrate over from Vime/Plyr.

We'll add support for detecting and loading Vimeo videos via the player src attribute. Examples:

  • src="vimeo/411652396"
  • src="https://vimeo.com/411652396"
  • src="https://player.vimeo.com/video/411652396"

The embed can be configured via the provider change event:

function onProviderChange(provider) {
  if (isVimeoProvider(provider)) {
    // configure it here
  }
}

When will it be ready?

It'll be ready before we officially announce 1.0. It should be within the month.

@stepanjakl
Copy link

Hi @mihar-22, what's the status on the support of Vimeo embeds? :)

@mihar-22
Copy link
Member Author

We're getting there, it'll be part of our 1.0 release. I don't have an exact date but this is one of the features I'll be working on in the coming week/s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants