Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy(): Reuse existing buffers whenever possible #65

Closed
karlrupp opened this issue Mar 9, 2014 · 1 comment
Closed

copy(): Reuse existing buffers whenever possible #65

karlrupp opened this issue Mar 9, 2014 · 1 comment
Assignees
Milestone

Comments

@karlrupp
Copy link
Collaborator

karlrupp commented Mar 9, 2014

At present, viennacl::copy() from host to device for non-proxy objects (e.g. vector, matrix) results in writing to a new buffer. We should reuse existing buffers if possible for two reasons:

  • The reallocation and destruction of buffers takes additional time
  • If the object only wraps a host buffer, the object after copy() will have it's own buffer rather than work with the user-provided buffer.
@karlrupp karlrupp added this to the Release 1.6.0 milestone Mar 9, 2014
@karlrupp karlrupp self-assigned this Mar 9, 2014
@karlrupp
Copy link
Collaborator Author

karlrupp commented Nov 1, 2014

Fixed here for dense matrices:
38aaea2
The use of injected handles with compressed_matrix is sufficiently well supported, no need for a more complicated copy() by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant